Page MenuHomePhabricator

(python-config-type-instance-18) Eliminate notion of "Regular" Config Type in core. Only Regular Type was Any
ClosedPublic

Authored by schrockn on Dec 7 2019, 6:26 PM.

Details

Summary

Any was the only type where this was used, so this is more
accurate. The notion of a "regular" type in the graphql layer means "Any
or Scalar" which is kind of "Scalar-ish". However not going to change
the verbiage in that layer.

Depends on D1596

Test Plan

BK. Load dagit.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 6:26 PM
schrockn updated this revision to Diff 7299.Dec 7 2019, 8:20 PM
schrockn retitled this revision from (python-config-type-instance-18) Eliminate notion of Regular Config Type. Any only instance of it to (python-config-type-instance-18) Eliminate notion of regular Config Type in core..
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

schrockn retitled this revision from (python-config-type-instance-18) Eliminate notion of regular Config Type in core. to (python-config-type-instance-18) Eliminate notion of "Regular" Config Type in core. Only Regular Type was Any.Dec 10 2019, 1:35 AM
schrockn updated this revision to Diff 7414.Dec 10 2019, 1:38 AM

upmessage

alangenfeld accepted this revision.Dec 10 2019, 1:39 AM

goodstuff

This revision is now accepted and ready to land.Dec 10 2019, 1:39 AM