Page MenuHomePhabricator

(python-config-type-instance-17) Consolidate config type hierarchy. Names for List and Optional
ClosedPublic

Authored by schrockn on Dec 7 2019, 5:59 PM.

Details

Summary

This consolidates the class hierarchy by elimiating a bunch of
unecessary classes. We also provide names to List and Optional to match
Set and Tuple. Now that we aren't enforcing unique name semantics this
makes more sense.

Depends on D1595

Test Plan

BK, Load dagit config editor

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 5:59 PM
schrockn updated this revision to Diff 7296.Dec 7 2019, 8:07 PM
schrockn retitled this revision from (python-config-type-instance-17) Consolidate config type hierarhcy to (python-config-type-instance-17) Consolidate config type hierarchy. Names for List and Optional.
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

alangenfeld accepted this revision.Dec 10 2019, 1:31 AM
alangenfeld added inline comments.
python_modules/dagster/dagster_tests/py3_tests/test_type_examples_py3.py
259–260

this is better right? i think so. makes me think of how the splitting of the runtime/config types could lead to better error messages

This revision is now accepted and ready to land.Dec 10 2019, 1:31 AM
schrockn added inline comments.Dec 10 2019, 1:32 AM
python_modules/dagster/dagster_tests/py3_tests/test_type_examples_py3.py
259–260

yes this is more accurate