Page MenuHomePhabricator

(python-config-type-instance-15) Disallow config class in config type codepaths. Eliminate ConfigType.inst()
ClosedPublic

Authored by schrockn on Dec 7 2019, 3:45 PM.

Details

Summary

I will follow up with another diff eliminating all inst()
callsites and noop inst() methods on types. Cutting this here
because this exposed a *nasty* bug where we weren't installing
an editable dagster-gcs in the airflow docker image

Depends on D1593

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 3:45 PM
schrockn updated this revision to Diff 7286.Dec 7 2019, 5:05 PM
schrockn retitled this revision from (python-config-type-instance-15) Eliminate all inst() methods to (python-config-type-instance-15) Disallow config class in config type codepaths. Eliminate ConfigType.inst().
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

schrockn added a subscriber: nate.Dec 7 2019, 5:16 PM

cc: @nate on the airflow change.

python_modules/dagster-airflow/dagster_airflow_tests/test_project/Dockerfile
12

khan

alangenfeld accepted this revision.Dec 10 2019, 1:22 AM
alangenfeld added inline comments.
python_modules/dagster-airflow/dagster_airflow_tests/test_project/Dockerfile
12

brutal

python_modules/dagster/dagster/core/types/config.py
94

byebye

This revision is now accepted and ready to land.Dec 10 2019, 1:22 AM