Page MenuHomePhabricator

(python-config-type-instance-14) Move Set and Tuple over to instance model Set
ClosedPublic

Authored by schrockn on Dec 7 2019, 3:29 PM.

Details

Summary

Continuing picking these off.

Depends on D1592

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 3:29 PM
schrockn updated this revision to Diff 7284.Dec 7 2019, 4:43 PM
schrockn retitled this revision from (python-config-type-instance-14) Move Set and Tuple over to instance model Set to (python-config-type-instance-14) Move Set and Tuple over to instance model Set.
schrockn edited the summary of this revision. (Show Details)

upmessage

alangenfeld accepted this revision.Dec 10 2019, 1:20 AM

in the name of progress

python_modules/dagster/dagster/core/types/config.py
356–395

should we just remove these from config space?

This revision is now accepted and ready to land.Dec 10 2019, 1:20 AM

Yeah I think so. Will do so after all this ish lands