Page MenuHomePhabricator

(python-config-type-instance-11) Move custom types in GCP module to config type instance
ClosedPublic

Authored by schrockn on Dec 7 2019, 3:04 PM.

Details

Summary

We will probably eliminate the ability to override ConfigScalars in this
fashion, but in the interim move it to an instance model.

Depends on D1589

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 3:04 PM
alangenfeld accepted this revision.Dec 10 2019, 1:01 AM

pidgey

python_modules/libraries/dagster-gcp/dagster_gcp/bigquery/types.py
120–147

should we tag these with an issue # or something so we dont forget about em?

This revision is now accepted and ready to land.Dec 10 2019, 1:01 AM
schrockn added inline comments.Dec 10 2019, 1:05 AM
python_modules/libraries/dagster-gcp/dagster_gcp/bigquery/types.py
120–147

good idea

schrockn updated this revision to Diff 7398.Dec 10 2019, 1:06 AM

feedback

This revision was landed with ongoing or failed builds.Dec 10 2019, 1:20 AM
This revision was automatically updated to reflect the committed changes.