Page MenuHomePhabricator

(python-config-type-instance-8) Type resolution in the config schema module does not accept config type classes
ClosedPublic

Authored by schrockn on Dec 7 2019, 8:25 AM.

Details

Summary

This is an odd function that does a subset of the config type resolving that only the config schema
(the config schema project from the runtime types specifically). With the changes so far we can lock
it down to not accept the config classes, so we do that here.

Depends on D1586

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 8:25 AM
alangenfeld accepted this revision.Dec 10 2019, 12:12 AM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/types/config_schema.py
39–40

oh i forgot Nullable was still around under the wrapping

This revision is now accepted and ready to land.Dec 10 2019, 12:12 AM
This revision was landed with ongoing or failed builds.Dec 10 2019, 1:04 AM
This revision was automatically updated to reflect the committed changes.