Page MenuHomePhabricator

(python-config-type-instance-7) Move NamedDict to instance model
ClosedPublic

Authored by schrockn on Dec 7 2019, 8:11 AM.

Details

Summary

Continue the long march. Moving NamedDict over to be an instance model

Depends on D1585

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 8:11 AM
alangenfeld accepted this revision.Dec 10 2019, 12:11 AM
alangenfeld added inline comments.
python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_definition_errors.py
140–155

whats the plan / purpose of NamedDict in this brave new world?

This revision is now accepted and ready to land.Dec 10 2019, 12:11 AM
This revision was landed with ongoing or failed builds.Dec 10 2019, 1:03 AM
This revision was automatically updated to reflect the committed changes.