Page MenuHomePhabricator

(python-config-type-instance-4) DictTypeApi move to wrapping.
ClosedPublic

Authored by schrockn on Dec 7 2019, 7:59 AM.

Details

Summary

This makes much more sense here. I will also name it
DagsterDictApi in a follow on (will cause merge pain to rename here)
and also rationalize all the usage of the "Api" classes (e.g. should
we do instance checks on them or only check for the singleton instance)

Depends on D1582

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 7 2019, 7:59 AM

charizard

python_modules/dagster/dagster/core/types/wrapping.py
103

nit: this one subclasses object and others dont? not sure it matters since these are transitionary

alangenfeld accepted this revision.Dec 10 2019, 12:02 AM
This revision is now accepted and ready to land.Dec 10 2019, 12:02 AM
schrockn added inline comments.Dec 10 2019, 12:20 AM
python_modules/dagster/dagster/core/types/wrapping.py
103

yeah was just a copy-paste job. I actually don't have a coherent view of the world in terms of when the py2 old-versus-new ish rears it's ugly head