Page MenuHomePhabricator

(python-config-type-instance-1) It begins. The config type instance migration.
ClosedPublic

Authored by schrockn on Dec 7 2019, 7:45 AM.

Details

Summary

This is the beginning of the process of moving over the config
type system to be instance-based, rather than class-based. We
set up the core machinery to handle config type instances and then
move NamedSelector over to support it as an example.

Depends on D1579

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn updated this revision to Diff 7263.Dec 7 2019, 7:45 AM
schrockn created this revision.

up

Harbormaster completed remote builds in B5859: Diff 7263.
schrockn updated this revision to Diff 7351.Dec 9 2019, 11:49 PM

feedback

alangenfeld accepted this revision.Dec 9 2019, 11:58 PM

soitbegins

python_modules/dagster/dagster/core/types/field.py
68–72

nothing ages quite as well as a dated comment about a migration

python_modules/dagster/dagster/core/types/wrapping.py
40–60 ↗(On Diff #7351)

hellothere

This revision is now accepted and ready to land.Dec 9 2019, 11:58 PM
schrockn added inline comments.Dec 10 2019, 12:09 AM
python_modules/dagster/dagster/core/types/wrapping.py
40–60 ↗(On Diff #7351)

ha yeah rebase will catch this

schrockn added inline comments.Dec 10 2019, 12:27 AM
python_modules/dagster/dagster/core/types/field.py
68–72

it goes away!

This revision was landed with ongoing or failed builds.Dec 10 2019, 12:28 AM
This revision was automatically updated to reflect the committed changes.