Page MenuHomePhabricator

(python-typing-to-inference-3) Explictly disallow typing types in the config system
ClosedPublic

Authored by schrockn on Dec 7 2019, 4:05 AM.

Details

Summary

Adding an explicit error message when someone passing in typing types
into a config context

Depends on D1573

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn updated this revision to Diff 7239.Dec 7 2019, 4:05 AM
schrockn created this revision.

up

Harbormaster failed remote builds in B5835: Diff 7239!
alangenfeld accepted this revision.Dec 9 2019, 11:43 PM

fix typo

python_modules/dagster/dagster/core/types/field.py
98

Typing from

types from

This revision is now accepted and ready to land.Dec 9 2019, 11:43 PM
schrockn updated this revision to Diff 7363.Dec 10 2019, 12:15 AM

conflict with master test