Page MenuHomePhabricator

[dagster aws] s3 fake improvements
ClosedPublic

Authored by alangenfeld on Dec 6 2019, 7:09 PM.

Details

Summary
  • expose fake s3 creation at the top
  • add has_object
  • allow buckets to be set from create_ call
Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Dec 6 2019, 7:09 PM
nate accepted this revision.Dec 6 2019, 7:29 PM

at some point might want to build this on top of moto S3 https://github.com/spulec/moto but fine for now

This revision is now accepted and ready to land.Dec 6 2019, 7:29 PM
This revision was automatically updated to reflect the committed changes.