Page MenuHomePhabricator

[core] remove redundant step level calls
ClosedPublic

Authored by alangenfeld on Dec 6 2019, 1:11 AM.

Details

Summary

remove API that encourages building the toposorted deps twice. This was an easier path then memoizing on a namedtuple

Test Plan

unit - profiler run to verify improvement

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Dec 6 2019, 1:11 AM
schrockn accepted this revision.Dec 6 2019, 1:13 AM
schrockn added inline comments.
python_modules/dagster/dagster/core/execution/plan/plan.py
317–318

rm

This revision is now accepted and ready to land.Dec 6 2019, 1:13 AM
alangenfeld updated this revision to Diff 7150.Dec 6 2019, 1:14 AM

delete dont comment

This revision was automatically updated to reflect the committed changes.