Page MenuHomePhabricator

[dagit] Fix wrapping in sidebar, disable reflow of fan-out
ClosedPublic

Authored by bengotow on Dec 5 2019, 11:39 PM.

Details

Summary

I updated the sidebar to wrap the pipeline, solid and IO names because things were basically useless. Thanks to "zero width space" characters, we can wrap on the underscores in the solid names which keeps things easy to read.

Test Plan

Updated snapshots

Diff Detail

Repository
R1 dagster
Branch
sfbg/bigdag-zoom
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

bengotow created this revision.Dec 5 2019, 11:39 PM
bengotow edited the summary of this revision. (Show Details)Dec 5 2019, 11:39 PM
bengotow updated this revision to Diff 7143.Dec 6 2019, 12:10 AM
  • Also fix issue with "black fill" appearing on external connection lines when viewing a composite (for unknown reason)
  • Turn off "max per row" code intended to wrap long lines of solids into blocks, does not work well on new example

My only concern is that this is too tailored towards our current examples and will have an adverse effect on dags where there is no correlation between naming and distance

bengotow planned changes to this revision.Dec 6 2019, 6:51 AM

Yeah that's a good point—I'll omit the edge weighting for now so we can push in the rest of these fixes. Long term it'd be kind of nice if users could choose between a couple graph layout algorithms but I agree this approach may work only for their DAG.

bengotow updated this revision to Diff 7156.Dec 6 2019, 6:59 AM

Disable weighting based on name similarity, update tests

bengotow retitled this revision from Weight DAG edges by solid name similarity, fix wrapping in sidebar to [dagit] Fix wrapping in sidebar, disable reflow of fan-out.Dec 6 2019, 7:00 AM
bengotow edited the summary of this revision. (Show Details)
schrockn edited the summary of this revision. (Show Details)Dec 6 2019, 3:39 PM
schrockn accepted this revision.Dec 6 2019, 3:46 PM
schrockn added inline comments.
js_modules/dagit/src/graph/getFullSolidLayout.ts
120

rm?

This revision is now accepted and ready to land.Dec 6 2019, 3:46 PM
bengotow added inline comments.Dec 6 2019, 6:16 PM
js_modules/dagit/src/graph/getFullSolidLayout.ts
120

Ahh will do!

bengotow updated this revision to Diff 7170.Dec 6 2019, 6:18 PM

Removing weighting method

This revision was landed with ongoing or failed builds.Dec 6 2019, 6:19 PM
This revision was automatically updated to reflect the committed changes.