Page MenuHomePhabricator

Construct all config types in environment schema
ClosedPublic

Authored by schrockn on Dec 5 2019, 6:29 PM.

Details

Summary

We now track all the closed generic types (e.g. Optional and
List) in the environment schema and allow them to be looked up by
key.

Test Plan

BK and navigate around config editor with D1542 applied

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 5 2019, 6:29 PM
schrockn updated this revision to Diff 7127.Dec 5 2019, 9:40 PM
schrockn retitled this revision from Get Ben's diff working to Construct all config types in environment schema.
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: alangenfeld, bengotow.

upmessage

schrockn updated this revision to Diff 7128.Dec 5 2019, 9:41 PM

actually delete test

alangenfeld accepted this revision.Dec 5 2019, 9:43 PM

illallowit

python_modules/dagster/dagster/core/types/iterate_types.py
7–8

put a sticky note on your monitor or something so we dont let this go

This revision is now accepted and ready to land.Dec 5 2019, 9:43 PM
This revision was automatically updated to reflect the committed changes.