Page MenuHomePhabricator

[dagster-graphql] memoize solid handle computation
ClosedPublic

Authored by alangenfeld on Dec 4 2019, 10:46 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Dec 4 2019, 10:46 PM
alangenfeld planned changes to this revision.Dec 5 2019, 12:05 AM

bad

alangenfeld updated this revision to Diff 7108.Dec 5 2019, 12:52 AM

now with working memoization

python_modules/dagster-graphql/dagster_graphql/schema/pipelines.py
40–50

went for this since @lru_cache doesn't work in py2

max accepted this revision.Dec 5 2019, 11:05 PM
max added inline comments.
python_modules/dagster-graphql/dagster_graphql/schema/pipelines.py
40–50

there is also functools32

This revision is now accepted and ready to land.Dec 5 2019, 11:05 PM
alangenfeld updated this revision to Diff 7137.Dec 5 2019, 11:23 PM

lru_cache + functools32

alangenfeld updated this revision to Diff 7138.Dec 5 2019, 11:32 PM

move again

This revision was automatically updated to reflect the committed changes.