Page MenuHomePhabricator

[graphql] improve solidHandle fields
ClosedPublic

Authored by alangenfeld on Dec 4 2019, 9:35 PM.

Details

Summary

To allow us to fetch data incrementally instead of all at once

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Dec 4 2019, 9:35 PM
bengotow accepted this revision.Dec 4 2019, 9:36 PM

LGTM!

python_modules/dagster-graphql/dagster_graphql/schema/pipelines.py
50–52

Minor nit but I wonder if this should be parentHandleID in case we have another ID format in the future?

This revision is now accepted and ready to land.Dec 4 2019, 9:36 PM
alangenfeld updated this revision to Diff 7100.Dec 4 2019, 9:37 PM

parentHandleID

alangenfeld updated this revision to Diff 7102.Dec 4 2019, 9:50 PM

make graphql

This revision was automatically updated to reflect the committed changes.