Page MenuHomePhabricator

Hang created EnvironmentSchemas off of pipeline definition
ClosedPublic

Authored by schrockn on Tue, Dec 3, 12:00 AM.

Details

Summary

During the normal course of execution we were creating the EnvironmentSchema
twice. This solves this systematically (e.g. will be cached in between invocations
to dagit).

Before:

After:

Test Plan

BK. See attached screenshots.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Tue, Dec 3, 12:00 AM
schrockn edited the summary of this revision. (Show Details)Tue, Dec 3, 12:01 AM
alangenfeld accepted this revision.Tue, Dec 3, 1:31 AM

mmm low hanging fruit

python_modules/dagster/dagster/core/definitions/pipeline.py
201–203

could try to use the memoizing decorator

This revision is now accepted and ready to land.Tue, Dec 3, 1:31 AM
schrockn updated this revision to Diff 7065.Tue, Dec 3, 3:13 AM

fancy functools.lru_cache

schrockn updated this revision to Diff 7066.Tue, Dec 3, 3:23 AM

go back to old diff (also differential is so good)