D1479 created the standalone schedule page. This diff links it from the schedules list view, and formats the attempts table a little bit to take into account pipeline run state.
Details
Details
- Reviewers
sashank - Commits
- R1:af5fd29a27e8: link schedule page
Viewed schedule page, saw both successful and unsuccessful attempts
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is great!
| js_modules/dagit/src/schedules/ScheduleRow.tsx | ||
|---|---|---|
| 79–85 | Could you explain what match is doing here? | |
Comment Actions
From Slack: Would be nice for the 5th column in the top bar to show attempts instead of runs, so that the colors match up with the attempts list
| js_modules/dagit/src/schedules/ScheduleRow.tsx | ||
|---|---|---|
| 79–85 | yeah, match is non-null if it matches the /schedule/:scheduleName route. We check it so that we don't show a link if we're already on the page that we're linking to. | |
Comment Actions
Looks great! Just two minor suggestions
| js_modules/dagit/src/schedules/ScheduleRow.tsx | ||
|---|---|---|
| 187–196 | What do you think about wrapping this in a Tooltip too that reads "Click to show error", just for consistency <Tooltip
position={"top"}
content={"Click to show error"}
wrapperTagName="div"
targetTagName="div"
>
<AttemptStatus status={attempt.status} />
</Tooltip> | |
| python_modules/dagster-graphql/dagster_graphql/schema/run_schedule.py | ||
| 153 | [1] | |
| 202 | Maybe we should extract this and [1] to a function so that paths don't get out of sync | |