Page MenuHomePhabricator

Move database interactions from airline demo to dagster-postgres and dagster-aws
Needs RevisionPublic

Authored by nate on Sun, Dec 1, 5:35 PM.

Details

Summary

gets us closer to being able to claim support for Redshift

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
move_redshift
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

nate created this revision.Sun, Dec 1, 5:35 PM
nate edited the summary of this revision. (Show Details)Sun, Dec 1, 7:10 PM
alangenfeld requested changes to this revision.Mon, Dec 2, 10:14 PM

bringing these small utilities in libraries has a breaking-changeable surface area cost associated with it - so we should be thoughtful that the value provided surmounts that cost

python_modules/libraries/dagster-aws/dagster_aws/redshift/utils.py
4

does bool arg really make sense here or should we be taking the prefix as an arg

note: i have no idea what jdbc is

skeptical

python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
30

*

This revision now requires changes to proceed.Mon, Dec 2, 10:14 PM

agree with alex. i don't think these have hit the level of utility yet to warrant incorporation to a library that we are on the hook supporting