Page MenuHomePhabricator

[EMR 2/N] Refresh Spark solid
AcceptedPublic

Authored by nate on Sun, Dec 1, 6:27 AM.

Details

Reviewers
alangenfeld
Summary

Pulling in part of D1330 as a (mostly) non-breaking change - will pull in the EMR-related parts of D1330 in the next diff

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
aws_emr_2_spark
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

nate created this revision.Sun, Dec 1, 6:27 AM
nate edited the summary of this revision. (Show Details)Sun, Dec 1, 6:30 AM
nate updated this revision to Diff 7029.Sun, Dec 1, 6:46 AM

fix snapshot

nate edited the summary of this revision. (Show Details)Sun, Dec 1, 6:52 AM
nate added a reviewer: alangenfeld.
alangenfeld accepted this revision.Mon, Dec 2, 10:05 PM

if you do want to land any minor breaking changes - make sure to note them in changes.md so we dont lose track

python_modules/libraries/dagster-spark/dagster_spark/solids.py
88–112

what are these changes for - this seems unrelated?

This revision is now accepted and ready to land.Mon, Dec 2, 10:05 PM