Page MenuHomePhabricator

Disable Re-execute and Retry when pipeline is unavailabe in repo (#1759)
ClosedPublic

Authored by bengotow on Nov 29 2019, 8:22 PM.

Details

Summary

This diff makes a few changes to handle pipelines not being available in the current repo:

  • On the runs list view, the contextual menu items for Re-execute and "Open in Execute Tab..." are disabled.
  • On the run detail view, the buttons for "Re-execute" and "Retry" are disabled and have informative tooltips.

Test Plan

Updated snapshot tests. I tested this manually by running log_spew and then deleting the log_spew pipeline from the demo repository and clicking "Reload" to update Dagit.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Nov 29 2019, 8:22 PM
bengotow edited the summary of this revision. (Show Details)Nov 29 2019, 8:27 PM
bengotow edited the test plan for this revision. (Show Details)
bengotow updated this revision to Diff 7006.Nov 29 2019, 8:29 PM

Update snapshot tests

schrockn requested changes to this revision.Nov 30 2019, 2:16 AM
schrockn added a subscriber: schrockn.

We should also consider the case where the configuration has changed and can no longer be parsed.

This revision now requires changes to proceed.Nov 30 2019, 2:16 AM

Hmm I think the changed-configuration scenario currently breaks the retrieval of the pipeline entirely and the UI doesn't load? @alangenfeld / @schrockn I might need some context on how we should address that one—based on https://github.com/dagster-io/dagster/issues/1910, I assume we need to change the way runs are retrieved so that the config can be UnknownConfig? Although it seems it should still be viewable, just not re-used for execution. But without upfront interpretation, we wouldn't realize that the config was invalid until we tried to start execution with it, and wouldn't be able to disable the button in the UI.

schrockn accepted this revision.Dec 1 2019, 7:43 PM

yeah let's go ahead and merge this.

This revision is now accepted and ready to land.Dec 1 2019, 7:43 PM