Differential D1513

Add input and output labels to invocations panel in dagit (#1503)
ClosedPublic
Actions

Authored by bengotow on Nov 29 2019, 7:46 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

R1:b29e510f1e6a: Add input and output labels to invocations panel in dagit (#1503)

Summary

See screenshot. I also made these headers conditionally appear only if there are rows beneath:

Test Plan

Updated snapshot tests

Diff Detail

Repository

Branch

ghbengotow/1503

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

bengotow created this revision.Nov 29 2019, 7:46 PM

bengotow edited the summary of this revision. (Show Details)Nov 29 2019, 7:48 PM

Harbormaster completed remote builds in B5647: Diff 7002.Nov 29 2019, 7:54 PM

schrockn accepted this revision.Nov 30 2019, 2:16 AM

This revision is now accepted and ready to land.Nov 30 2019, 2:16 AM

Closed by commit R1:b29e510f1e6a: Add input and output labels to invocations panel in dagit (#1503) (authored by Ben Gotow <ben@foundry376.com>). · Explain WhyNov 30 2019, 3:27 PM

This revision was automatically updated to reflect the committed changes.

Ben Gotow <ben@foundry376.com> added a commit: R1:b29e510f1e6a: Add input and output labels to invocations panel in dagit (#1503).

Revision Contents
Changeset List

			Path	Packages
M			js_modules/dagit/src/SidebarSolidHelpers.tsx (19 lines)
M			js_modules/dagit/src/SidebarSolidInvocation.tsx (15 lines)
M			js_modules/dagit/src/__tests__/__snapshots__/App.test.tsx.snap (86 lines)

Diff 7002

js_modules/dagit/src/SidebarSolidHelpers.tsx

Loading...

js_modules/dagit/src/SidebarSolidInvocation.tsx

Loading...

js_modules/dagit/src/tests/snapshots/App.test.tsx.snap

Loading...