Page MenuHomePhabricator

Check-in expected failure repros for #1950 and #1949
ClosedPublic

Authored by schrockn on Nov 28 2019, 12:28 AM.

Details

Summary

So while working on D1494 I encountered what I would consider either
bugs or mystifying behavior. It seems that the resource mapping stuff is untested
and has been broken for some time, or else I am confused regarding what is going on.

So it does not appear to work when using required_resource_keys #1949 and if you
don't use required_resource_keys it also doesn't work #1950.

Test Plan

run tests unskipped and see them break.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Nov 28 2019, 12:28 AM
nate accepted this revision.Dec 1 2019, 4:30 PM

good finds - let's get this landed

This revision is now accepted and ready to land.Dec 1 2019, 4:30 PM
schrockn updated this revision to Diff 7050.Dec 2 2019, 10:14 PM

change from skip to xfail

schrockn retitled this revision from Check-in skipped repros for #1950 and #1949 to Check-in expected failure repros for #1950 and #1949.Dec 2 2019, 10:21 PM
This revision was automatically updated to reflect the committed changes.