Page MenuHomePhabricator

Allow frozenset in set_param checks
ClosedPublic

Authored by schrockn on Nov 27 2019, 9:36 PM.

Details

Summary

Where appropriate, I think we should start to use frozenset instead
of sets. Yesterday I had a nasty nasty bug where test order effected whether
or not a set passes. A reference to set was changed and effected a subsequent
run. I used a frozenset to debug the issue and would have prevented the bug
in the first place (as in the error would be made obvious)

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Nov 27 2019, 9:36 PM
alangenfeld accepted this revision.Nov 27 2019, 9:44 PM

should probably grab dict/list also - file ticket as "good first issue" if you want to defer it

This revision is now accepted and ready to land.Nov 27 2019, 9:44 PM
This revision was automatically updated to reflect the committed changes.