Page MenuHomePhabricator

Make mode required in environment class construction
ClosedPublic

Authored by schrockn on Nov 26 2019, 12:02 AM.

Details

Summary

This was written in a time in place where mode was optional. Now if the user does not specify a mode in a pipeline
one is created on their behalf. Take advantage of the new modeful world to eliminate a dead code path.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Nov 26 2019, 12:02 AM
schrockn updated this revision to Diff 6900.Nov 26 2019, 12:14 AM
schrockn edited the summary of this revision. (Show Details)

upmessage

schrockn updated this revision to Diff 6901.Nov 26 2019, 12:16 AM

upmessage

This revision is now accepted and ready to land.Nov 26 2019, 12:46 AM
This revision was automatically updated to reflect the committed changes.