Page MenuHomePhabricator

Add dagster instance migrate CLI tool
ClosedPublic

Authored by max on Nov 25 2019, 6:16 PM.

Details

Summary

Support migration of Dagster instances.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D1480
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Nov 25 2019, 6:16 PM
alangenfeld requested changes to this revision.Nov 25 2019, 9:26 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
204–206

if there are no callsites maybe just drop this? better to keep details from leaking if they are not needed

306–313

I don't think we should expose these - lets just add an upgrade method here

This revision now requires changes to proceed.Nov 25 2019, 9:26 PM
alangenfeld added inline comments.Nov 25 2019, 9:28 PM
python_modules/dagster/dagster/core/instance/__init__.py
306–313

motivation: so far we've avoided exposing these such that we could have an instance not composed of these exact components and nothing should break

max added inline comments.Nov 25 2019, 10:46 PM
python_modules/dagster/dagster/core/instance/__init__.py
306–313

ok agree completely

max updated this revision to Diff 7082.Dec 3 2019, 9:47 PM

Nits

alangenfeld accepted this revision.Dec 10 2019, 10:17 PM

+ to changes.md - can cover in other diff

This revision is now accepted and ready to land.Dec 10 2019, 10:17 PM
max updated this revision to Diff 7599.Dec 11 2019, 10:47 PM

Rebase

max updated this revision to Diff 7617.Dec 12 2019, 12:35 AM

Add test data

max updated this revision to Diff 7618.Dec 12 2019, 12:38 AM

Reorg

Harbormaster failed remote builds in B6154: Diff 7618!
max updated this revision to Diff 7657.Dec 12 2019, 11:53 PM

Tests

max updated this revision to Diff 7662.Dec 13 2019, 12:49 AM

Rebase

max updated this revision to Diff 7668.Dec 13 2019, 5:11 AM

Rebase

max updated this revision to Diff 7673.Dec 13 2019, 5:50 AM

undebug

alangenfeld added inline comments.Dec 13 2019, 5:16 PM
python_modules/dagster/dagster/core/execution/stats.py
10–18 ↗(On Diff #7673)

is this not covered by check.generator or something like that?

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/test_back_compat.py
13–57 ↗(On Diff #7673)

add some comments about the high level purpose of this test - not obvious to me

max added inline comments.Dec 13 2019, 6:48 PM
python_modules/dagster/dagster/core/execution/stats.py
10–18 ↗(On Diff #7673)

no, i don't think so

python_modules/dagster/dagster/core/instance/__init__.py
204–206

yep

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/test_back_compat.py
13–57 ↗(On Diff #7673)

ok

max updated this revision to Diff 7688.Dec 13 2019, 6:48 PM

Add comments on test

max updated this revision to Diff 7706.Dec 13 2019, 11:01 PM

Update migration scripts

max updated this revision to Diff 7721.Dec 14 2019, 1:09 AM

Rebase

max updated this revision to Diff 7723.Dec 14 2019, 1:43 AM

Rootdir

max updated this revision to Diff 7726.Dec 14 2019, 1:57 AM

Rebase

This revision was automatically updated to reflect the committed changes.