Page MenuHomePhabricator

Add dagster instance migrate CLI tool
Needs ReviewPublic

Authored by max on Mon, Nov 25, 6:16 PM.

Details

Reviewers
alangenfeld
Summary

Support migration of Dagster instances.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D1480_1
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Mon, Nov 25, 6:16 PM
alangenfeld requested changes to this revision.Mon, Nov 25, 9:26 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
205–207

if there are no callsites maybe just drop this? better to keep details from leaking if they are not needed

307–314

I don't think we should expose these - lets just add an upgrade method here

This revision now requires changes to proceed.Mon, Nov 25, 9:26 PM
alangenfeld added inline comments.Mon, Nov 25, 9:28 PM
python_modules/dagster/dagster/core/instance/__init__.py
307–314

motivation: so far we've avoided exposing these such that we could have an instance not composed of these exact components and nothing should break

max added inline comments.Mon, Nov 25, 10:46 PM
python_modules/dagster/dagster/core/instance/__init__.py
307–314

ok agree completely

max updated this revision to Diff 7082.Tue, Dec 3, 9:47 PM

Nits