Page MenuHomePhabricator

(incremental-meta-4) Using meta to power EnvironmentSchema
ClosedPublic

Authored by schrockn on Nov 23 2019, 11:24 PM.

Details

Summary

This adds an alternative way of constructing the config type
dauphin classes, using the meta objects. We then power the
EnvironmentSchema.allConfigTypes field using it.

We also use it to powere configTypeOrError on EnvironmentSchema.

Eliminate duplicative root call at configTypeError

Worth noting that there might be an argument for keeping the root
version instead.

Test Plan

DK and use dagit.

Diff Detail

Repository
R1 dagster
Branch
incremental-meta-new-4
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Nov 23 2019, 11:24 PM
schrockn updated this revision to Diff 6852.Nov 24 2019, 1:02 AM
schrockn added reviewers: max, alangenfeld.

upmessage

alangenfeld accepted this revision.Nov 25 2019, 9:18 PM

seems legit

This revision is now accepted and ready to land.Nov 25 2019, 9:18 PM
Harbormaster failed remote builds in B5565: Diff 6894!