Page MenuHomePhabricator

Collapse WatchableEventLogStorage onto EventLogStorage
ClosedPublic

Authored by max on Nov 23 2019, 1:13 AM.

Details

Diff Detail

Repository
R1 dagster
Branch
watchable-event-logs
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Nov 23 2019, 1:13 AM
max updated this revision to Diff 6826.Nov 23 2019, 1:46 AM

Rebase

alangenfeld requested changes to this revision.Nov 25 2019, 5:32 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
306–307

just remove the callsite and this function

This revision now requires changes to proceed.Nov 25 2019, 5:32 PM
max updated this revision to Diff 6859.Nov 25 2019, 6:17 PM

Remove callsite for can_watch_events

This revision is now accepted and ready to land.Nov 25 2019, 8:54 PM
max updated this revision to Diff 6896.Nov 25 2019, 11:28 PM

Rebase