Page MenuHomePhabricator

Collapse WatchableEventLogStorage onto EventLogStorage
ClosedPublic

Authored by max on Sat, Nov 23, 1:13 AM.

Details

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Sat, Nov 23, 1:13 AM
max updated this revision to Diff 6826.Sat, Nov 23, 1:46 AM

Rebase

alangenfeld requested changes to this revision.Mon, Nov 25, 5:32 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
306–307

just remove the callsite and this function

This revision now requires changes to proceed.Mon, Nov 25, 5:32 PM
max updated this revision to Diff 6859.Mon, Nov 25, 6:17 PM

Remove callsite for can_watch_events

This revision is now accepted and ready to land.Mon, Nov 25, 8:54 PM
max updated this revision to Diff 6896.Mon, Nov 25, 11:28 PM

Rebase