Differential D1472

Collapse WatchableEventLogStorage onto EventLogStorage
ClosedPublic
Actions

Authored by max on Sat, Nov 23, 1:13 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage

Summary

Stacked on D1470.

Test Plan

Unit

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Sat, Nov 23, 1:13 AM

max mentioned this in D1471: Refactor SQL-based event log storages to use SQLAlchemy.Sat, Nov 23, 1:19 AM

Harbormaster failed remote builds in B5505: Diff 6820!Sat, Nov 23, 1:21 AM

Up

Harbormaster failed remote builds in B5510: Diff 6825!Sat, Nov 23, 1:30 AM

Rebase

max mentioned this in D1473: Scaffold alembic.Sat, Nov 23, 1:52 AM

Harbormaster completed remote builds in B5511: Diff 6826.Sat, Nov 23, 1:54 AM

alangenfeld requested changes to this revision.Mon, Nov 25, 5:32 PM

alangenfeld added inline comments.

python_modules/dagster/dagster/core/instance/__init__.py
306–307	just remove the callsite and this function

This revision now requires changes to proceed.Mon, Nov 25, 5:32 PM

Remove callsite for can_watch_events

Harbormaster completed remote builds in B5538: Diff 6859.Mon, Nov 25, 6:28 PM

redparty

This revision is now accepted and ready to land.Mon, Nov 25, 8:54 PM

Rebase

Harbormaster completed remote builds in B5566: Diff 6896.Mon, Nov 25, 11:37 PM

Closed by commit R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage (authored by Max Gasner <max.gasner@gmail.com>). · Explain WhyTue, Nov 26, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Max Gasner <max.gasner@gmail.com> added a commit: R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage.

Max Gasner <max.gasner@gmail.com> mentioned this in R1:2c05c51f514b: Scaffold alembic.Tue, Nov 26, 7:39 PM

Revision Contents
Changeset List

			Path	Packages
M			python_modules/dagster-graphql/dagster_graphql/implementation/execution.py (11 lines)
M			python_modules/dagster/dagster/core/instance/__init__.py (11 lines)
M			python_modules/dagster/dagster/core/storage/event_log/__init__.py (7 lines)
M			python_modules/dagster/dagster/core/storage/event_log/event_log.py (14 lines)
M			python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py (6 lines)
M			python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py (4 lines)

Diff 6914

python_modules/dagster-graphql/dagster_graphql/implementation/execution.py

Loading...

python_modules/dagster/dagster/core/instance/init.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/init.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/event_log.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

Loading...

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

Loading...