Page MenuHomePhabricator
Differential D1472

Collapse WatchableEventLogStorage onto EventLogStorage
ClosedPublic
Actions

Authored by max on Nov 23 2019, 1:13 AM.

Details

Reviewers
alangenfeld
Commits
R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage
Summary

Stacked on D1470.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Nov 23 2019, 1:13 AM
max mentioned this in D1471: Refactor SQL-based event log storages to use SQLAlchemy.Nov 23 2019, 1:19 AM
Harbormaster failed remote builds in B5505: Diff 6820!Nov 23 2019, 1:21 AM
max updated this revision to Diff 6825.Nov 23 2019, 1:22 AM

Up

Harbormaster failed remote builds in B5510: Diff 6825!Nov 23 2019, 1:30 AM
max updated this revision to Diff 6826.Nov 23 2019, 1:46 AM

Rebase

max mentioned this in D1473: Scaffold alembic.Nov 23 2019, 1:52 AM
Harbormaster completed remote builds in B5511: Diff 6826.Nov 23 2019, 1:54 AM
alangenfeld requested changes to this revision.Nov 25 2019, 5:32 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/instance/__init__.py
306–307

just remove the callsite and this function

This revision now requires changes to proceed.Nov 25 2019, 5:32 PM
max updated this revision to Diff 6859.Nov 25 2019, 6:17 PM

Remove callsite for can_watch_events

Harbormaster completed remote builds in B5538: Diff 6859.Nov 25 2019, 6:28 PM
alangenfeld accepted this revision.Nov 25 2019, 8:54 PM

redparty

This revision is now accepted and ready to land.Nov 25 2019, 8:54 PM
max updated this revision to Diff 6896.Nov 25 2019, 11:28 PM

Rebase

Harbormaster completed remote builds in B5566: Diff 6896.Nov 25 2019, 11:37 PM
Closed by commit R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage (authored by max). · Explain WhyNov 26 2019, 5:28 PM
This revision was automatically updated to reflect the committed changes.
Max Gasner <max.gasner@gmail.com> added a commit: R1:c877d3cdc59c: Collapse WatchableEventLogStorage onto EventLogStorage.
Max Gasner <max.gasner@gmail.com> mentioned this in R1:2c05c51f514b: Scaffold alembic.Nov 26 2019, 7:39 PM
Max Gasner <max.gasner@gmail.com> mentioned this in R1:85e04ad4d5e8: Refactor SQL-based event log storages to use SQLAlchemy.Dec 13 2019, 5:35 AM

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
implementation/
11 lines
dagster/
dagster/
core/
instance/
11 lines
storage/
event_log/
7 lines
14 lines
sqlite/
6 lines
libraries/
dagster-postgres/
dagster_postgres/
event_log/
4 lines

Diff 6914

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution.py

Loading...
View Options

python_modules/dagster/dagster/core/instance/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/event_log.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

Loading...
View Options

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

Loading...