Page MenuHomePhabricator

[docs] Enum & fixes
ClosedPublic

Authored by alangenfeld on Nov 20 2019, 4:54 PM.

Details

Test Plan

in docs

make livehtml

see no errors (other than ipynb files)

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Nov 20 2019, 4:54 PM
alangenfeld updated this revision to Diff 6747.Nov 20 2019, 5:15 PM

remove wtf line

themissinghlink accepted this revision.Nov 20 2019, 6:13 PM

This looks good to me! Since we are doing doc changes, it might be a good idea to also have a screen shot of the effected pages just to make sure we aren't pushing up bad changes (It also makes it easier for folks to review)?

python_modules/dagster/dagster/core/types/config.py
397

Why are we defining EnumValues when we are already specifying Enums above? It looks very verbose? (Also should be fixed in a different revision, that's just a question for me XD).

This revision is now accepted and ready to land.Nov 20 2019, 6:13 PM
alangenfeld added inline comments.Nov 20 2019, 6:59 PM
python_modules/dagster/dagster/core/types/config.py
397

EnumValue is the wrapper class that allows you to specify other (optional) information in addition to just the entry in the enum. It behaves much like Field does for Dicts

This revision was automatically updated to reflect the committed changes.