Page MenuHomePhabricator
Differential D1439

Rename configDefinition to configField
ClosedPublic
Actions

Authored by schrockn on Nov 15 2019, 10:53 PM.

Details

Reviewers
alangenfeld
Commits
R1:7a78623dc429: Rename configDefinition to configField
Summary

This is a callback to a time long, long ago where there
was a separate concept of a "ConfigDefinition" distinct from a field

Test Plan

ts, load dagit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Nov 15 2019, 10:53 PM
alangenfeld accepted this revision.Nov 15 2019, 10:59 PM

whynot

This revision is now accepted and ready to land.Nov 15 2019, 10:59 PM
Harbormaster failed remote builds in B5337: Diff 6625!Nov 15 2019, 11:01 PM
schrockn updated this revision to Diff 6628.Nov 15 2019, 11:32 PM

update mocks

Harbormaster completed remote builds in B5339: Diff 6628.Nov 15 2019, 11:39 PM
Closed by commit R1:7a78623dc429: Rename configDefinition to configField (authored by schrockn). · Explain WhyNov 15 2019, 11:40 PM
This revision was automatically updated to reflect the committed changes.
schrockn added a commit: R1:7a78623dc429: Rename configDefinition to configField.

Revision Contents
Changeset List

Diff 6630

View Options

js_modules/dagit/src/SidebarSolidDefinition.tsx

Loading...
View Options

js_modules/dagit/src/__tests__/__data__/PIPELINE_EXPLORER_ROOT_QUERY.json

Loading...
View Options

js_modules/dagit/src/__tests__/__data__/ROOT_PIPELINES_QUERY.json

Loading...
View Options

js_modules/dagit/src/__tests__/__data__/SOLIDS_ROOT_QUERY.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_ingest_pipeline.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_warehouse_pipeline.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/composition.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/fan_in_fan_out_pipeline.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/log_spew.json

Loading...
View Options

js_modules/dagit/src/__tests__/graph/__data__/many_events.json

Loading...
View Options

js_modules/dagit/src/execute/types/SolidSelectorQuery.ts

Loading...
View Options

js_modules/dagit/src/graph/SolidNode.tsx

Loading...
View Options

js_modules/dagit/src/graph/types/PipelineGraphSolidFragment.ts

Loading...
View Options

js_modules/dagit/src/graph/types/SolidNodeDefinitionFragment.ts

Loading...
View Options

js_modules/dagit/src/schema.graphql

Loading...
View Options

js_modules/dagit/src/solids/types/SolidCardSolidDefinitionFragment.ts

Loading...
View Options

js_modules/dagit/src/solids/types/SolidsRootQuery.ts

Loading...
View Options

js_modules/dagit/src/types/PipelineExplorerRootQuery.ts

Loading...
View Options

js_modules/dagit/src/types/PipelineExplorerSolidHandleFragment.ts

Loading...
View Options

js_modules/dagit/src/types/SidebarSolidDefinitionFragment.ts

Loading...
View Options

js_modules/dagit/src/types/SidebarTabbedContainerSolidFragment.ts

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_misc.py

Loading...