Rename configDefinition to configField
ClosedPublic
Actions

Authored by schrockn on Nov 15 2019, 10:53 PM.

Details

Reviewers

Commits

R1:7a78623dc429: Rename configDefinition to configField

Summary

This is a callback to a time long, long ago where there
was a separate concept of a "ConfigDefinition" distinct from a field

Test Plan

ts, load dagit

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schrockn created this revision.Nov 15 2019, 10:53 PM

whynot

This revision is now accepted and ready to land.Nov 15 2019, 10:59 PM

Harbormaster failed remote builds in B5337: Diff 6625!Nov 15 2019, 11:01 PM

update mocks

Harbormaster completed remote builds in B5339: Diff 6628.Nov 15 2019, 11:39 PM

Closed by commit R1:7a78623dc429: Rename configDefinition to configField (authored by schrockn). · Explain WhyNov 15 2019, 11:40 PM

This revision was automatically updated to reflect the committed changes.

schrockn added a commit: R1:7a78623dc429: Rename configDefinition to configField.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

src/

SidebarSolidDefinition.tsx

10 lines

__tests__/

__data__/

PIPELINE_EXPLORER_ROOT_QUERY.json

ROOT_PIPELINES_QUERY.json

SOLIDS_ROOT_QUERY.json

graph/

__data__/

airline_demo_ingest_pipeline.json

airline_demo_warehouse_pipeline.json

composition.json

fan_in_fan_out_pipeline.json

log_spew.json

many_events.json

execute/

types/

SolidSelectorQuery.ts

graph/

SolidNode.tsx

8 lines

types/

PipelineGraphSolidFragment.ts

SolidNodeDefinitionFragment.ts

schema.graphql

2 lines

solids/

types/

SolidCardSolidDefinitionFragment.ts

SolidsRootQuery.ts

types/

PipelineExplorerRootQuery.ts

PipelineExplorerSolidHandleFragment.ts

SidebarSolidDefinitionFragment.ts

SidebarTabbedContainerSolidFragment.ts

python_modules/

dagster-graphql/

dagster_graphql/

schema/

solids.py

4 lines

dagster_graphql_tests/

graphql/

conftest.py

2 lines

test_misc.py

2 lines

Diff 6630

View Options

js_modules/dagit/src/SidebarSolidDefinition.tsx

View Options

js_modules/dagit/src/tests/data/PIPELINE_EXPLORER_ROOT_QUERY.json

View Options

js_modules/dagit/src/tests/data/ROOT_PIPELINES_QUERY.json

View Options

js_modules/dagit/src/tests/data/SOLIDS_ROOT_QUERY.json

View Options

js_modules/dagit/src/tests/graph/data/airline_demo_ingest_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/airline_demo_warehouse_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/composition.json

View Options

js_modules/dagit/src/tests/graph/data/fan_in_fan_out_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/log_spew.json

View Options

js_modules/dagit/src/tests/graph/data/many_events.json

View Options

js_modules/dagit/src/execute/types/SolidSelectorQuery.ts

View Options

js_modules/dagit/src/graph/SolidNode.tsx

View Options

js_modules/dagit/src/graph/types/PipelineGraphSolidFragment.ts

View Options

js_modules/dagit/src/graph/types/SolidNodeDefinitionFragment.ts

View Options

js_modules/dagit/src/schema.graphql

View Options

js_modules/dagit/src/solids/types/SolidCardSolidDefinitionFragment.ts

View Options

js_modules/dagit/src/solids/types/SolidsRootQuery.ts

View Options

js_modules/dagit/src/types/PipelineExplorerRootQuery.ts

View Options

js_modules/dagit/src/types/PipelineExplorerSolidHandleFragment.ts

View Options

js_modules/dagit/src/types/SidebarSolidDefinitionFragment.ts

View Options

js_modules/dagit/src/types/SidebarTabbedContainerSolidFragment.ts

View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_misc.py

Rename configDefinition to configFieldClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6630

js_modules/dagit/src/SidebarSolidDefinition.tsx

js_modules/dagit/src/__tests__/__data__/PIPELINE_EXPLORER_ROOT_QUERY.json

js_modules/dagit/src/__tests__/__data__/ROOT_PIPELINES_QUERY.json

js_modules/dagit/src/__tests__/__data__/SOLIDS_ROOT_QUERY.json

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_ingest_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_warehouse_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/composition.json

js_modules/dagit/src/__tests__/graph/__data__/fan_in_fan_out_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/log_spew.json

js_modules/dagit/src/__tests__/graph/__data__/many_events.json

js_modules/dagit/src/execute/types/SolidSelectorQuery.ts

js_modules/dagit/src/graph/SolidNode.tsx

js_modules/dagit/src/graph/types/PipelineGraphSolidFragment.ts

js_modules/dagit/src/graph/types/SolidNodeDefinitionFragment.ts

js_modules/dagit/src/schema.graphql

js_modules/dagit/src/solids/types/SolidCardSolidDefinitionFragment.ts

js_modules/dagit/src/solids/types/SolidsRootQuery.ts

js_modules/dagit/src/types/PipelineExplorerRootQuery.ts

js_modules/dagit/src/types/PipelineExplorerSolidHandleFragment.ts

js_modules/dagit/src/types/SidebarSolidDefinitionFragment.ts

js_modules/dagit/src/types/SidebarTabbedContainerSolidFragment.ts

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_misc.py

Rename configDefinition to configField
ClosedPublic
Actions

Revision Contents
Changeset List

js_modules/dagit/src/tests/data/PIPELINE_EXPLORER_ROOT_QUERY.json

js_modules/dagit/src/tests/data/ROOT_PIPELINES_QUERY.json

js_modules/dagit/src/tests/data/SOLIDS_ROOT_QUERY.json

js_modules/dagit/src/tests/graph/data/airline_demo_ingest_pipeline.json

js_modules/dagit/src/tests/graph/data/airline_demo_warehouse_pipeline.json

js_modules/dagit/src/tests/graph/data/composition.json

js_modules/dagit/src/tests/graph/data/fan_in_fan_out_pipeline.json

js_modules/dagit/src/tests/graph/data/log_spew.json

js_modules/dagit/src/tests/graph/data/many_events.json