Page MenuHomePhabricator

Add UI for partitions in Dagit
AbandonedPublic

Authored by prha on Fri, Nov 15, 12:35 AM.

Details

Reviewers
alangenfeld
bengotow
sashank
Group Reviewers
Restricted Project
Summary

This diff adds a new schedule-specific page in Dagit. It's main purpose is to visualize and re-execute partitions, and view debugging information.

The UI is a rough first pass, and still needs work. We can put this behind a feature flag to keep it hidden until the Partition API is public with the 0.7.0 release.

Test Plan

Diff Detail

Repository
R1 dagster
Branch
partition-2
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank created this revision.Fri, Nov 15, 12:35 AM
sashank edited the summary of this revision. (Show Details)Fri, Nov 15, 9:00 PM
sashank edited the test plan for this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)
sashank added a reviewer: Restricted Project.
sashank updated this revision to Diff 6602.Fri, Nov 15, 9:04 PM
sashank edited the summary of this revision. (Show Details)

rebase

sashank edited the summary of this revision. (Show Details)Fri, Nov 15, 10:05 PM
sashank edited the summary of this revision. (Show Details)
sashank updated this revision to Diff 6617.Fri, Nov 15, 10:06 PM

Remove re-execute button

sashank updated this revision to Diff 6618.Fri, Nov 15, 10:12 PM

refactor

sashank updated this revision to Diff 6619.Fri, Nov 15, 10:13 PM

update snapshots

alangenfeld requested changes to this revision.Wed, Nov 20, 4:05 PM
alangenfeld added a reviewer: bengotow.
alangenfeld added subscribers: prha, bengotow, alangenfeld.

I assume @prha is going to commandeer this.

I think this standalone schedule page is good to add in the short term to provide a way to surface attempts and runs more explicitly with more screen real estate. Probably worth getting some input from @bengotow on ways to improve it visually.

This revision now requires changes to proceed.Wed, Nov 20, 4:05 PM
prha commandeered this revision.Wed, Nov 20, 6:09 PM
prha added a reviewer: sashank.

ahoy

Just a few drive-by comments on the JS!

js_modules/dagit/src/schedules/ScheduleRoot.tsx
121

I don't /think/ the key here is necessary - if it is we may want to investigate why!

168

This is just a random drive-by nit, but I wonder if the partition's chunk could be called sliceKey or segment or value to avoid partition.partition?

js_modules/dagit/src/schedules/ScheduleRow.tsx
132

Would probably be ideal to switch this to <Link> - the Link tag runs a react-router transition in it's onClick, so you get a slightly smoother transition to the next page (the page doesn't flash white briefly like it does with a).

prha abandoned this revision.Mon, Dec 9, 5:12 PM