Page MenuHomePhabricator

Extract ScheduleRow component to its own file
ClosedPublic

Authored by sashank on Thu, Nov 14, 10:41 PM.

Details

Reviewers
prha
Group Reviewers
Restricted Project
Commits
R1:f794baa783af: Extract ScheduleRow component to its own file
Summary

Extracting the ScheduleRow component to it's own file to use it in multiple places in upcoming diffs

Test Plan

Load scheduler page, verify it is the same

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Thu, Nov 14, 10:41 PM
sashank added reviewers: prha, Restricted Project.Thu, Nov 14, 10:42 PM
prha added inline comments.Thu, Nov 14, 11:36 PM
js_modules/dagit/src/schema.graphql
931 ↗(On Diff #6563)

what's going on here? Is this based off of a dauphin change that's not included here?

sashank updated this revision to Diff 6568.Fri, Nov 15, 12:36 AM

make graphql

sashank added inline comments.Fri, Nov 15, 12:40 AM
js_modules/dagit/src/schema.graphql
931 ↗(On Diff #6563)

thanks for the catch – had to run make graphql

prha accepted this revision.Fri, Nov 15, 2:17 AM

looks good!

This revision is now accepted and ready to land.Fri, Nov 15, 2:17 AM