Page MenuHomePhabricator

[instance] remove features system

Authored by alangenfeld on Nov 13 2019, 5:05 PM.



This is currently unused and not the right implementation given newer abstractions like ConfigurableClass. I think we can do a better job when we need it (or just revert chunks of this diff).

My motivation for cleaning this up is to provide a cleaner "override" ability for loading an instance which I think we'll need for the execution server / run queue

Test Plan

bk & lint

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Nov 13 2019, 5:05 PM
max added a comment.Nov 13 2019, 6:00 PM

I don't like the features system but I still think we need a way to feature-flag front-end functionality. Maybe it's about starting dagit with explicit flags?

ya we will need something but I'm not sure exactly what so I think we can build what we need once we need it

This revision is now accepted and ready to land.Nov 13 2019, 6:22 PM
alangenfeld updated this revision to Diff 6507.Nov 13 2019, 6:22 PM

further removal

I was going to use this again for some of the schedule partition work to hide sections within Dagit until 0.7.0. But since it makes it easier to implement the override ability, it makes sense to get rid of this.

This revision was automatically updated to reflect the committed changes.