Page MenuHomePhabricator

[windows] fix dagit cli
ClosedPublic

Authored by alangenfeld on Fri, Nov 8, 7:27 PM.

Details

Reviewers
prha
Group Reviewers
Restricted Project
Commits
R1:21d03f24e59f: [windows] fix dagit cli
Summary

execvp is non blocking so this used to just return immediately

instead of using another process in the sync case lets just call dagit

Test Plan

dagit --help
dagit --version
dagit -y examples/repository.yaml # with forcing watch_for_reload to false

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Fri, Nov 8, 7:27 PM
prha accepted this revision.Fri, Nov 8, 7:48 PM
prha added a subscriber: prha.

lgtm

This revision is now accepted and ready to land.Fri, Nov 8, 7:48 PM
This revision was landed with ongoing or failed builds.Mon, Nov 11, 4:09 PM
This revision was automatically updated to reflect the committed changes.