Page MenuHomePhabricator

Make previous_run_id an optional arg on ExecutionParams
AbandonedPublic

Authored by sashank on Fri, Nov 8, 6:45 PM.

Details

Reviewers
prha
Summary

Since previous_run_id is an opt_str_param, the argument in the constructor should have a default so that it's not required to be set.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
prev-run-id-opt
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank updated this revision to Diff 6400.Fri, Nov 8, 6:45 PM
sashank created this revision.

up

Now realizing there might have been a reason you decided to make the constructor not have a default value so that you have to be explicit about previous_run_id=None. If so, happy to abandon this.

prha accepted this revision.Fri, Nov 8, 6:54 PM

no, this looks fine, but I think unnecessary?

environment_dict and step_keys are also optional...

This revision is now accepted and ready to land.Fri, Nov 8, 6:54 PM
sashank abandoned this revision.Fri, Nov 8, 7:18 PM

Agreed actually - this is unnecessary