Page MenuHomePhabricator

Add basic test docs
ClosedPublic

Authored by max on Thu, Nov 7, 10:36 PM.

Details

Reviewers
alangenfeld
themissinghlink
Group Reviewers
Restricted Project
Commits
R1:645baa373766: Add basic test docs
Summary

Simple examples of tests.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Thu, Nov 7, 10:36 PM
max updated this revision to Diff 6375.Thu, Nov 7, 10:50 PM

Isort

This is awesome. Could you also put up a preview screen shot of the docs showing the rendered view of this? I obviously trust you that this works, however, it helps with scrollback if we were to refer to this diff at any point should something go wrong and it makes my job as a reviewer easier!

docs/sections/learn/tutorial/hello_cereal.rst
195

I would either elaborate in a sentence or two as to why this is true or take this out. I think we should let the system speak for itself, and if we want to call stuff out then we ought to demonstrate the differences which you are doing, but it is a bit distracting.

docs/sections/learn/tutorial/inputs.rst
187

I love this example! Great work. RE above, could we maybe contrast why this would be hard to find in a different setup (like airflow where this solid would just be a block of code in an otherwise large PythonOperator?

themissinghlink accepted this revision.Fri, Nov 8, 7:45 PM

To unblock you.

This revision is now accepted and ready to land.Fri, Nov 8, 7:45 PM
This revision was automatically updated to reflect the committed changes.