Page MenuHomePhabricator

remove unused examples/requirements.txt file
ClosedPublic

Authored by prha on Thu, Nov 7, 6:21 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:b189ba8b0b57: remove unused examples/requirements.txt file
Summary

We refer to pip install -e examples[full] in the Makefile and in our documentation.

Test Plan

bk, ran local make install_dev_python_modules

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Thu, Nov 7, 6:21 PM
max added a subscriber: max.Thu, Nov 7, 7:01 PM

Do we need this requirements.txt at all?

prha abandoned this revision.Thu, Nov 7, 7:06 PM

abandoning in favor of https://dagster.phacility.com/D1380

I think we might not need it? The documentation on readthedocs uses pip install -e .[full]

prha reclaimed this revision.Thu, Nov 7, 7:22 PM
prha updated this revision to Diff 6340.Thu, Nov 7, 7:25 PM

remove

prha retitled this revision from split example requirements to remove unused examples/requirements.txt file.Thu, Nov 7, 7:27 PM
prha edited the summary of this revision. (Show Details)
prha edited the test plan for this revision. (Show Details)
prha updated this revision to Diff 6341.Thu, Nov 7, 7:29 PM

rebase right branch

prha updated this revision to Diff 6348.Thu, Nov 7, 7:44 PM

remove reference in airline demo dockerfile

max accepted this revision.Thu, Nov 7, 7:46 PM

Hooray

This revision is now accepted and ready to land.Thu, Nov 7, 7:46 PM
This revision was automatically updated to reflect the committed changes.