Page MenuHomePhabricator

fix dagster examples tox file
ClosedPublic

Authored by alangenfeld on Wed, Nov 6, 10:26 PM.

Details

Summary

we're not running a bunch of tests

Test Plan

weap

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Wed, Nov 6, 10:26 PM
alangenfeld updated this revision to Diff 6310.Wed, Nov 6, 10:42 PM

dagster-dbt

alangenfeld added inline comments.
examples/dagster_examples/jaffle_dbt/jaffle.py
13–16

what do we actually want done in CI around this?

prha added a subscriber: prha.Wed, Nov 6, 10:48 PM

ah, i just started to run into this...

prha accepted this revision.Wed, Nov 6, 10:49 PM
This revision is now accepted and ready to land.Wed, Nov 6, 10:49 PM
alangenfeld updated this revision to Diff 6312.Wed, Nov 6, 10:50 PM
alangenfeld removed a reviewer: prha.

snapshot update

This revision now requires review to proceed.Wed, Nov 6, 10:50 PM

don't know what happened to remove @prha

prha accepted this revision.Wed, Nov 6, 10:55 PM
This revision is now accepted and ready to land.Wed, Nov 6, 10:55 PM
prha added a comment.Wed, Nov 6, 10:55 PM

lol, feel like that's the second time that's happened...

alangenfeld added inline comments.Wed, Nov 6, 10:55 PM
examples/dagster_examples/jaffle_dbt/jaffle.py
13–16

im going to land this to unblock - will let @sashank find the best path forward in D1376

alangenfeld updated this revision to Diff 6314.Wed, Nov 6, 10:57 PM

dont let black

alangenfeld updated this revision to Diff 6315.Wed, Nov 6, 11:01 PM

dont isort snapshots

sashank added inline comments.Wed, Nov 6, 11:04 PM
examples/dagster_examples/jaffle_dbt/jaffle.py
13–16

Abandoned D1376 since it's a duplicate of this fix - tracking here: https://github.com/dagster-io/dagster/issues/1893

alangenfeld updated this revision to Diff 6316.Wed, Nov 6, 11:37 PM

sort that list

alangenfeld updated this revision to Diff 6318.Wed, Nov 6, 11:50 PM

install req.txt

This revision was automatically updated to reflect the committed changes.