Page MenuHomePhabricator

pin ecdsa (moto dep), which has import resolving issues
ClosedPublic

Authored by prha on Wed, Nov 6, 8:58 PM.

Details

Reviewers
natekupp
Group Reviewers
Restricted Project
Commits
R1:6d0c3deb2c8a: pin ecdsa (moto dep), which has import resolving issues
Summary

I'm not 100% sure why the import started failing, but there's some dark and nefarious python dependency resolution evil happening here.

@natekupp, @max, feel free to chime in on why this solution is bad...

Here's what I think is going on...

  • ecdsa package releases 0.14, which removes their internal copy-pastad version of six and actually uses the six module
  • In our tests, we pip install six@1.13, which does export the requested resource
  • For some reason, in the ecdsa package, the import fails.

I ignored all that and just pinned ecdsa to 0.13 which has the internally bundled version of six so tests would stop failing.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Wed, Nov 6, 8:58 PM
prha updated this revision to Diff 6302.Wed, Nov 6, 9:03 PM

black

prha updated this revision to Diff 6303.Wed, Nov 6, 9:05 PM

requirements

Harbormaster failed remote builds in B5069: Diff 6302!
prha edited the summary of this revision. (Show Details)Wed, Nov 6, 9:16 PM
prha added a reviewer: Restricted Project.
prha edited the summary of this revision. (Show Details)
prha added a subscriber: max.
prha added a subscriber: natekupp.
natekupp accepted this revision.Wed, Nov 6, 9:26 PM

thanks for sleuthing this. sounds reasonable to me

This revision is now accepted and ready to land.Wed, Nov 6, 9:26 PM
This revision was automatically updated to reflect the committed changes.