Page MenuHomePhabricator

switch posix to use signal handlers to kill compute log tail processes
ClosedPublic

Authored by prha on Wed, Nov 6, 6:56 PM.

Details

Summary

retested, saw builds run fine.

locally, this ran through our unittests faster than the polling version, which waits a polling interval before killing the tail process

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Wed, Nov 6, 6:56 PM
prha edited the summary of this revision. (Show Details)Wed, Nov 6, 9:46 PM
prha added a reviewer: Restricted Project.
alangenfeld accepted this revision.Thu, Nov 7, 4:34 PM
alangenfeld added a subscriber: alangenfeld.

goforit

This revision is now accepted and ready to land.Thu, Nov 7, 4:34 PM