Page MenuHomePhabricator

fix terminate in multiprocess engine
ClosedPublic

Authored by alangenfeld on Wed, Nov 6, 5:05 PM.

Details

Summary

Overlooked this when terminate was getting implemented.

Test Plan

new test case
terminate the same pipeline with single and multiprocess engines - verify that experience is the same

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Wed, Nov 6, 5:05 PM
alangenfeld planned changes to this revision.Wed, Nov 6, 5:09 PM

need to make sure this kills all the children

child_processes

alangenfeld updated this revision to Diff 6300.Wed, Nov 6, 7:36 PM

handle multiple active children in multiproc

alangenfeld updated this revision to Diff 6304.Wed, Nov 6, 9:11 PM

fix tests

alangenfeld updated this revision to Diff 6331.Thu, Nov 7, 5:00 PM

comments and clean up

max accepted this revision.Thu, Nov 7, 9:51 PM

so fresh and clean

python_modules/dagster/dagster/core/engine/child_process_executor.py
16–31

yay

This revision is now accepted and ready to land.Thu, Nov 7, 9:51 PM
This revision was automatically updated to reflect the committed changes.