Page MenuHomePhabricator

Guard against inscrutable error messages when passing badly-behaved values in place of types
AbandonedPublic

Authored by max on Tue, Nov 5, 9:49 PM.

Details

Reviewers
alangenfeld
schrockn
Group Reviewers
Restricted Project
Summary

Resolves https://github.com/dagster-io/dagster/issues/1717.

This is illustrative of the confusion in the type system we discussed this morning, particularly
that this change has to be made in three places.

This solves for an exotic class of inscrutable errors that arise when ill-behaved objects
(either nonhashable or noncomparable) find their way into APIs that expect to see types or the
typealikes from typing, etc.

Stacked on D1364
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
pandas_df_error
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Tue, Nov 5, 9:49 PM

is there any way to not have to repeat this and start the refactor process of cleaning up all this mess?

schrockn requested changes to this revision.Wed, Nov 6, 12:09 AM

yeah there's gotta be a less fragile way to do this

This revision now requires changes to proceed.Wed, Nov 6, 12:09 AM
max abandoned this revision.Thu, Nov 7, 7:02 PM

Less fragile solution to follow on D1382