Page MenuHomePhabricator

Docs & example
ClosedPublic

Authored by max on Tue, Nov 5, 6:43 PM.

Details

Reviewers
alangenfeld
schrockn
Group Reviewers
Restricted Project
Commits
R1:2fb1577c47e2: Docs & example
Summary
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Tue, Nov 5, 6:43 PM
alangenfeld added inline comments.Tue, Nov 5, 9:00 PM
python_modules/dagster/dagster/core/definitions/decorators.py
341–342

I forget - why do we have two things and whats the difference?

max added a subscriber: natekupp.Tue, Nov 5, 10:04 PM
max added inline comments.
python_modules/dagster/dagster/core/definitions/decorators.py
341–342

step_metadata_fn is run at execution plan creation time (?) and is used only to support the display of the templated spark submit command in dagit for the spark solids. @natekupp has a plan to rework those solids, and we are tracking removal of this parameter at https://github.com/dagster-io/dagster/issues/1883. metadata is just arbitrary keys you set on the solid.

This revision is now accepted and ready to land.Tue, Nov 5, 10:45 PM
This revision was automatically updated to reflect the committed changes.