Page MenuHomePhabricator

[RFC] Make Selector directly instantiable class
AbandonedPublic

Authored by max on Nov 5 2019, 3:17 AM.

Details

Reviewers
None
Summary

This isn't for commit, but I don't think it is
too crazy to do this in a reasonable way.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
new-selector
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Nov 5 2019, 3:17 AM
max added a comment.Wed, Nov 20, 7:21 PM

i like this approach, should i commandeer this and get it mergeable some day when i can't think about anything else?

Sure that works. I think the field hash stuff makes it more safe too which is great

Sent via Superhuman iOS ( https://sprh.mn/?vip=schrockn@elementl.com )

max commandeered this revision.Fri, Nov 22, 2:01 AM
max edited reviewers, added: schrockn; removed: max.
max removed a reviewer: schrockn.
max abandoned this revision.Tue, Dec 10, 2:00 AM