Page MenuHomePhabricator

Support run retry
ClosedPublic

Authored by prha on Nov 5 2019, 1:10 AM.

Details

Reviewers
bengotow
max
Group Reviewers
Restricted Project
Commits
R1:875357b3a7a3: Support run retry
Summary

Depends on D1336, which simplifies run step reexecution to a retryRunId (previous run id) and the set of steps that should be re-executed.

This diff introduces logic in the graphql startPipelineExecution mutation that calculates the steps that should be executed to "retry" a previous run.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Nov 5 2019, 1:10 AM
prha edited the summary of this revision. (Show Details)Nov 5 2019, 1:20 AM
prha updated this revision to Diff 6277.Nov 6 2019, 12:33 AM
  • add graphql test to test retries
prha updated this revision to Diff 6284.EditedNov 6 2019, 1:05 AM
  • rename retry button
prha added a reviewer: Restricted Project.Nov 6 2019, 1:13 AM
max added a subscriber: max.Nov 6 2019, 5:43 PM

Can we provide any additional hints as to the semantic distinction between Re-execute and Resume / Retry? Tool tips?

Any other ideas on naming?

alangenfeld added subscribers: bengotow, alangenfeld.

@bengotow might have some good input on this UX

definitely want to sprinkle some tooltips on these buttons

prha updated this revision to Diff 6328.Nov 7 2019, 5:07 AM

tooltips

prha updated this revision to Diff 6353.Nov 7 2019, 9:44 PM

rebase

prha edited the summary of this revision. (Show Details)Nov 7 2019, 11:04 PM
max added inline comments.Nov 7 2019, 11:23 PM
js_modules/dagit/src/runs/Run.tsx
34

maybe prefer the imperative Re-execute. the question here is what does "current" mean (i.e., with the same config)

36

maybe: "Retries.. starting from the first failed step" or "Retries, skipping [recomputation for] any steps that succeeded"

prha updated this revision to Diff 6396.Nov 7 2019, 11:58 PM

clarify tooltip descriptions

max accepted this revision.Nov 12 2019, 7:09 PM
This revision is now accepted and ready to land.Nov 12 2019, 7:09 PM
This revision was automatically updated to reflect the committed changes.