Page MenuHomePhabricator

Fix compute log tail regression which orphans tail processes
ClosedPublic

Authored by prha on Wed, Oct 30, 7:09 PM.

Details

Summary

D1258 introduced a regression because in certain circumstances, the compute process killed the watcher process without killing the actual tail process.
This diff introduces signal handlers to kill the tail process when the watcher dies.

Test Plan

Ran solid that exited, made sure tail did not orphan... Also, ran solid that completed and killed tail watcher process, saw tail process terminate

Tracking implementation changes for better testing here: https://github.com/dagster-io/dagster/issues/1881

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Wed, Oct 30, 7:09 PM
prha updated this revision to Diff 6102.Wed, Oct 30, 11:48 PM

update

prha updated this revision to Diff 6104.Thu, Oct 31, 12:21 AM

update

prha updated this revision to Diff 6113.Thu, Oct 31, 4:47 PM

update

prha updated this revision to Diff 6114.Thu, Oct 31, 5:27 PM

try bumping dagstermill queue

prha updated this revision to Diff 6117.Thu, Oct 31, 6:02 PM

rebase

prha added a reviewer: Restricted Project.Thu, Oct 31, 6:16 PM
max accepted this revision.Thu, Oct 31, 9:12 PM
max added a subscriber: max.

Fine by me, let's loosen the masking on the snapshot test.

This revision is now accepted and ready to land.Thu, Oct 31, 9:12 PM
prha updated this revision to Diff 6128.Thu, Oct 31, 9:19 PM

loosen timing check in snapshots

prha updated this revision to Diff 6131.Thu, Oct 31, 9:22 PM

rebase

alangenfeld accepted this revision.Thu, Oct 31, 9:56 PM
alangenfeld added a subscriber: alangenfeld.

Macro limecat:  PROCEED

This revision was landed with ongoing or failed builds.Thu, Oct 31, 10:00 PM
This revision was automatically updated to reflect the committed changes.