Page MenuHomePhabricator

Loosen future dependency in outside of dagster-airflow
ClosedPublic

Authored by schrockn on Fri, Oct 25, 1:13 PM.

Details

Reviewers
max
natekupp
Group Reviewers
Restricted Project
Commits
R1:3a54c4639729: Loosen future dependency in outside of dagster-airflow
Summary

I don't believe we need to account for airflow's depedency
constraints in core dagster. If we loosen the dep here (I'm not sure
exactly what we rely on in dagster core) then when dagster-airflow
installs that will deal with their weird issues.

This is a mitigation. We should really be executing execution steps
in the airflow integration in a totally different virtual environment,
so we don't repeat Airflow's mistake of intermixing the orchestration
and compute environments.

Resolves https://github.com/dagster-io/dagster/issues/1869

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Fri, Oct 25, 1:13 PM
schrockn updated this revision to Diff 6002.Fri, Oct 25, 1:29 PM
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: Restricted Project, max, natekupp.

upmessage

schrockn updated this revision to Diff 6003.Fri, Oct 25, 1:29 PM
schrockn edited the summary of this revision. (Show Details)

upmessage

Harbormaster completed remote builds in B4814: Diff 6005.
schrockn retitled this revision from Loosen future dependency in dagster core to Loosen future dependency in outside of dagster-airflow.Fri, Oct 25, 2:07 PM
natekupp accepted this revision.Fri, Oct 25, 2:53 PM
This revision is now accepted and ready to land.Fri, Oct 25, 2:53 PM
This revision was automatically updated to reflect the committed changes.