Page MenuHomePhabricator

[RFC] make implicit OutputDefinition optional
AbandonedPublic

Authored by alangenfeld on Thu, Oct 24, 5:34 PM.

Details

Reviewers
natekupp
schrockn
Group Reviewers
Restricted Project
Summary
Test Plan

test case

Diff Detail

Repository
R1 dagster
Branch
implicit-out (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

alangenfeld created this revision.Thu, Oct 24, 5:34 PM
natekupp accepted this revision.Tue, Oct 29, 9:46 PM
natekupp added subscribers: max, natekupp.

ah, I really like this, its way simpler than other things we were discussing - @max how do you feel about it?

This revision is now accepted and ready to land.Tue, Oct 29, 9:46 PM
alangenfeld added inline comments.Tue, Oct 29, 9:58 PM
python_modules/dagster/dagster/core/definitions/inference.py
21

this does likely create a different unique behavior where if something gets wired up to this optional output and its not returned - the downstream steps will all skip

max added a comment.Thu, Oct 31, 7:48 PM

The new weird behavior is quite exotic

schrockn requested changes to this revision.Thu, Oct 31, 7:56 PM
schrockn added a subscriber: schrockn.

I'm a bit concerned about this. I think optional outputs are really an advanced feature that is used to do control flow. Let's think about an alternative solution.

This revision now requires changes to proceed.Thu, Oct 31, 7:56 PM
alangenfeld abandoned this revision.Thu, Oct 31, 10:00 PM

the other idea i had was to create subclasses ie ImplicitOutputDefinition and vary behavior based on that

abandon